PacificCommunity / ofp-sam-flr4mfcl

R Functions for Taming MULTIFAN-CL
7 stars 3 forks source link

Spatial Simulation Par file #19

Open mtvincen opened 1 year ago

mtvincen commented 1 year ago

The 09.par file from the spatial experiment simulation for the 4 region model appears to be reading the diff_coffs_age_period incorrectly. Found here: https://drive.google.com/drive/folders/1Kdje_In2Zs3Fllewf1vuw3vA6mJGNrYD It appears only the first 2 quarters are being read in and not all 4. I'm not quite sure what is wrong with it. I updated my versions just to be sure and this was what I was using: FLR4MFCL_1.3.27 FLCore_2.6.19.9004 iterators_1.0.14 lattice_0.20-44

robscott3 commented 1 year ago

Thanks Matt, I'll take a look at it. Could you send me the par file you are using (maybe to my spc mail).

In Honiara for the MOC atm but will look at this as soon as I can.

Cheers Rob

On Wed, 19 Oct 2022, 06:10 mtvincen, @.***> wrote:

The 09.par file from the spatial experiment simulation for the 4 region model appears to be reading the diff_coffs_age_period incorrectly. Found here: https://drive.google.com/drive/folders/1Kdje_In2Zs3Fllewf1vuw3vA6mJGNrYD It appears only the first 2 quarters are being read in and not all 4. I'm not quite sure what is wrong with it. I updated my versions just to be sure and this was what I was using: FLR4MFCL_1.3.27 FLCore_2.6.19.9004 iterators_1.0.14 lattice_0.20-44

— Reply to this email directly, view it on GitHub https://github.com/PacificCommunity/ofp-sam-flr4mfcl/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACB4ITTGTNFQ2347IKYROB3WD3Y3DANCNFSM6AAAAAARIMQ6Y4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

robscott3 commented 1 year ago

Ah just seen that you have provided a link already. Will take a look. R

On Wed, 19 Oct 2022, 06:10 mtvincen, @.***> wrote:

The 09.par file from the spatial experiment simulation for the 4 region model appears to be reading the diff_coffs_age_period incorrectly. Found here: https://drive.google.com/drive/folders/1Kdje_In2Zs3Fllewf1vuw3vA6mJGNrYD It appears only the first 2 quarters are being read in and not all 4. I'm not quite sure what is wrong with it. I updated my versions just to be sure and this was what I was using: FLR4MFCL_1.3.27 FLCore_2.6.19.9004 iterators_1.0.14 lattice_0.20-44

— Reply to this email directly, view it on GitHub https://github.com/PacificCommunity/ofp-sam-flr4mfcl/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACB4ITTGTNFQ2347IKYROB3WD3Y3DANCNFSM6AAAAAARIMQ6Y4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mtvincen commented 1 year ago

I've figured out a work around to do what I was working on. So no rush in fixing it. I just wanted to make the issue known because it wasn't apparent that there was a problem reading them it and it plots the movement in the diags package, it's just incorrect.

robscott3 commented 1 year ago

OK - thanks Matt, might get a chance to look at it over the weekend - I'll let you know.

On Thu, Oct 20, 2022 at 7:40 AM mtvincen @.***> wrote:

I've figured out a work around to do what I was working on. So no rush in fixing it. I just wanted to make the issue known because it wasn't apparent that there was a problem reading them it and it plots the movement in the diags package, it's just incorrect.

— Reply to this email directly, view it on GitHub https://github.com/PacificCommunity/ofp-sam-flr4mfcl/issues/19#issuecomment-1284547717, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACB4ITX4AKF3AAH5WTXS7U3WEBMDPANCNFSM6AAAAAARIMQ6Y4 . You are receiving this because you commented.Message ID: @.***>

robscott3 commented 1 year ago

Hi Matt, The problem was that the dimension for the movement coefficients was determined from the max value of the movement map (in your case 2, because you only have 2 different movement rates) and not from the length of the movement map (4, ie. the number of seasons).

This was a code change I implemented back in 2020 to get swordfish working - I will have to check swordfish to see if I have broken anything again - but it should (hopefully) be OK for you now.

Let me know if I can close the issue

Chrs, Rob