search

PacificEMIS / Pacific-SIS

1 stars 3 forks source link

Trying to reset a password in wrong school provides misleading feedback #627

Closed ghachey closed 10 months ago

ghachey commented 1 year ago

A bug that confuses users and waste time. It was reported twice, claimed as fixed but yet it persists.

https://github.com/PacificEMIS/Pacific-SIS/issues/8 https://github.com/PacificEMIS/Pacific-SIS/issues/490

Try to reset a password for a user without being in the user's first school. You will get a "Invalid email" feedback. This leaves users very confused. You need to actually know that you must change school for the password reset to work. This happens all the time especially when people look after more than one school.

Screenshot 2023-09-06 155534

A correct feedback would be something like "You need to be in the staff's first school to change the password". But better yet, simply allow the password reset to proceed as long as the user initiating it has permission to do so on that user.

ghachey commented 10 months ago

In branch develop this provides better feedback but still forces the switch to the first school of the user. This is unnecessary but at least now it is clear and not misleading.