PacificEMIS / Pacific-SIS

1 stars 3 forks source link

Course section allow conflict issue #631

Closed ghachey closed 11 months ago

ghachey commented 1 year ago

A typical case in allowing student and teacher conflict for course sections is something like two courses taught at the same time in the same classroom, same group of students and same teacher. The correct way to handle this is to use allow student conflict and allow teacher conflict when creating those course sections taught at the same time and same place. But the system does not allow this with the following error which makes the allow conflict feature clunky and not usable as intended.

Screenshot 2023-09-11 111910

A work-around is to create a secondary different classroom (for example Classroom 1 (b)) but this is unnatural and yet another confusing concept needed explanation for a common use case.

When the allow conflict features are enabled I think the check on the classroom should be ignored.

openSISAdmin commented 1 year ago

I would estimate this effort to be about 2-4 lines of code. Check if conflict value is enable and if so skip the classroom check. Or add a Allow Classroom Conflict flag. But seems the conflicts are usually for same course (hence likely same classroom) I think first approach is better.

GH

suman1611 commented 1 year ago

@Sabya-openSIS sir need api help

ghachey commented 1 year ago

I do see the new allow room conflict and does seem to work in the branch Development. However, in the view below it is not shown. While this is minor while you are working on this issue might as well show it. Also can we get this be pushed to production as soon as ready?

Screenshot 2023-09-14 220316

ghachey commented 11 months ago

This seems fixed now in develop. It is needed as soon as possible in production.