search

PacificEMIS / pacific-open-education-data

Pacific Open Education Data is a public Android/iOS app meant to disseminate publicly accessible education data with close integration with the Pacific EMIS
2 stars 0 forks source link

Add emis_url setting #4

Closed ghachey closed 1 year ago

ghachey commented 3 years ago

Just like the feature for the Pacific Education Survey Tool (see https://github.com/ghachey/pacific-emis-education-survey-tool/issues/14) a flexible means to set the location of the EMIS shall be added. Refer to screeshot below. Currently this value is hard coded in the app. It shall be editable in the fetched firebase config. You can keep the hard coded one as fallback but the one fetched from firebase setting shall take precedence. This is required if the URL changes over time.

emis_url-2

ghachey commented 3 years ago

While you add the emis_url setting into the configuration please also pull out the hard coded login user into here as well.

login

marinaomega commented 2 years ago

Feature is implemented in the latest build 1.1.4 37 Though, for now we update the config while we start the app, so the change will not be visible immediately. Is that critical?

ghachey commented 2 years ago

I'm not sure I am following here. Perhaps let's get on a call to further clarify this.

marinaomega commented 2 years ago

In other words, this setting will be available either 10 hours after the change (as configuration is updated once in 10h) or immediately by reinstalling the app

ghachey commented 2 years ago

How about closing the app and re-starting it (not full re-installation)

marinaomega commented 2 years ago

It's updated with first installation and once in 5 hours. We can implement it when restaring the app/closing the app but no more often than once in 2 hours

ghachey commented 2 years ago

I think this is all good.