PacifistMC / Forgix

A Gradle plugin/an Architectury addon to merge mod-loaders into one jar! 𝘸𝘒𝘩𝘩 𝘡𝘦𝘀𝘩𝘯𝘰𝘭𝘰𝘨𝘺
GNU Lesser General Public License v2.1
145 stars 6 forks source link

[MC 1.20.6] [Forgix 1.2.9] neoforge.mods.toml not updated with neoforge- prefix for mixin configuration #29

Open jason13official opened 5 months ago

jason13official commented 5 months ago

I'm using the MultiLoader-Template project (google-able), and attempting to merge common, fabric, and neoforge. The mixin files are prefixed with their loader after merging, such as fabric-examplemod.fabric.mixins.json, and neoforge-examplemod.neoforge.mixins.json. However when opening the merged jar with a tool such as WinRAR, the neoforge.mods.toml file has not been updated, causing a crash without a useful error log.

EDIT: I have the mixin file configured in forgix {} within build.gradle EDIT 2: I've made the repository public if it will help at all https://github.com/Cursee-Development/Danger-Close

hypherionmc commented 5 months ago

I am familiar with the template you mentioned.

Keep in mind that neoforge support is still experimental, and hasn't fully been tested. I will run some tests later today to see what can be done to fix it.

It also doesn't help that neoforge has two different ways of specifying mixins.... Older neoforge used the same MixinConfigs in the manifest like forge did, and newer neoforge supports both mods.toml and MixinConfigs in the manifest, making it harder to support, but not impossible

Edit: I see you are targeting 1.20.6, which makes it a bit easier to fix :smile:

jason13official commented 5 months ago

Thank you for a response πŸ™ For now I'm just manually updating the neoforge.mods.toml with WinRAR πŸ’€