PackageKit / PackageKit

A D-BUS abstraction layer that allows the user to manage packages in a secure way using a cross-distro, cross-architecture API.
https://www.freedesktop.org/software/PackageKit/
GNU General Public License v2.0
252 stars 163 forks source link

Build failure ( zypp backend ) #692

Open sidt4 opened 1 year ago

sidt4 commented 1 year ago

Compiled on Debian unstable:

$ ninja
[230/231] Compiling C++ object backends/zypp/libpk_backend_zypp.so.p/pk-backend-zypp.cpp.o
../backends/zypp/pk-backend-zypp.cpp:637:1: warning: no previous declaration for ‘gboolean zypp_logging()’ [-Wmissing-declarations]
  637 | zypp_logging ()
      | ^~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:683:1: warning: no previous declaration for ‘gboolean zypp_is_development_repo(zypp::RepoInfo)’ [-Wmissing-declarations]
  683 | zypp_is_development_repo (RepoInfo repo)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:692:1: warning: no previous declaration for ‘gboolean zypp_is_valid_repo(PkBackendJob*, zypp::RepoInfo)’ [-Wmissing-declarations]
  692 | zypp_is_valid_repo (PkBackendJob *job, RepoInfo repo)
      | ^~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:713:1: warning: no previous declaration for ‘zypp::ResPool zypp_build_pool(zypp::ZYpp::Ptr, gboolean)’ [-Wmissing-declarations]
  713 | zypp_build_pool (ZYpp::Ptr zypp, gboolean include_local)
      | ^~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:774:1: warning: no previous declaration for ‘zypp::target::rpm::RpmHeader::constPtr zypp_get_rpmHeader(const std::string&, zypp::Edition)’ [-Wmissing-declarations]
  774 | zypp_get_rpmHeader (const string &name, Edition edition)
      | ^~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:790:1: warning: no previous declaration for ‘PkGroupEnum get_enum_group(const std::string&)’ [-Wmissing-declarations]
  790 | get_enum_group (const string &group_)
      | ^~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:845:1: warning: no previous declaration for ‘void zypp_get_packages_by_name(const gchar*, zypp::ResKind, std::vector<zypp::sat::Solvable>&, gboolean)’ [-Wmissing-declarations]
  845 | zypp_get_packages_by_name (const gchar *package_name,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:867:1: warning: no previous declaration for ‘void zypp_get_packages_by_file(zypp::ZYpp::Ptr, const gchar*, std::vector<zypp::sat::Solvable>&)’ [-Wmissing-declarations]
  867 | zypp_get_packages_by_file (ZYpp::Ptr zypp,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:899:1: warning: no previous declaration for ‘bool zypp_package_is_local(const gchar*)’ [-Wmissing-declarations]
  899 | zypp_package_is_local (const gchar *package_id)
      | ^~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:920:1: warning: no previous declaration for ‘zypp::sat::Solvable zypp_get_package_by_id(const gchar*)’ [-Wmissing-declarations]
  920 | zypp_get_package_by_id (const gchar *package_id)
      | ^~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:985:1: warning: no previous declaration for ‘zypp::RepoInfo zypp_get_Repository(PkBackendJob*, const gchar*)’ [-Wmissing-declarations]
  985 | zypp_get_Repository (PkBackendJob *job, const gchar *alias)
      | ^~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:1175:1: warning: no previous declaration for ‘void zypp_emit_filtered_packages_in_list(PkBackendJob*, PkBitfield, const std::vector<zypp::sat::Solvable>&)’ [-Wmissing-declarations]
 1175 | zypp_emit_filtered_packages_in_list (PkBackendJob *job, PkBitfield filters, const vector<sat::Solvable> &v)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function ‘void zypp_backend_finished_error(PkBackendJob*, PkErrorEnum, const char*, ...)’:
../backends/zypp/pk-backend-zypp.cpp:1803:35: warning: function ‘void zypp_backend_finished_error(PkBackendJob*, PkErrorEnum, const char*, ...)’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 1803 |         buffer = g_strdup_vprintf (format, args);
      |                  ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function ‘void pk_backend_upgrade_system_thread(PkBackendJob*, GVariant*, gpointer)’:
../backends/zypp/pk-backend-zypp.cpp:3576:23: warning: unused variable ‘restart’ [-Wunused-variable]
 3576 |         PkRestartEnum restart = PK_RESTART_ENUM_NONE;
      |                       ^~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function ‘void backend_what_provides_thread(PkBackendJob*, GVariant*, gpointer)’:
../backends/zypp/pk-backend-zypp.cpp:3846:62: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
 3846 |                                                              (const gpointer) make<ResObject>(*it)->summary().c_str (),
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[231/231] Linking target backends/zypp/libpk_backend_zypp.so
sidt4 commented 2 months ago

Addressed in https://github.com/PackageKit/PackageKit/pull/786.

sidt4 commented 2 months ago

Build now fails with 45d31408e.

Below log from zypp CI job - https://github.com/PackageKit/PackageKit/actions/runs/10539250941/job/29202619365?pr=787

FAILED: backends/zypp/libpk_backend_zypp.so.p/pk-backend-zypp.cpp.o 
c++ -Ibackends/zypp/libpk_backend_zypp.so.p -Ibackends/zypp -I../backends/zypp -Isrc -I../src -Ilib/packagekit-glib2 -I../lib/packagekit-glib2 -Ilib -I../lib -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -Wall -Winvalid-pch -Wextra -O0 -g -DPK_COMPILATION -Wall -Wcast-align -Wno-uninitialized -Werror=missing-declarations -Wredundant-decls -Wpointer-arith -Wcast-align -Wwrite-strings -Winit-self -Wreturn-type -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wmissing-format-attribute -Wclobbered -Wempty-body -Wignored-qualifiers -Wsign-compare -Wtype-limits -Wuninitialized -Wno-unused-parameter -fPIC -pthread -D_FILE_OFFSET_BITS=64 '-DG_LOG_DOMAIN="PackageKit-Zypp"' -Wall -Woverloaded-virtual -Wnon-virtual-dtor -std=c++1z -MD -MQ backends/zypp/libpk_backend_zypp.so.p/pk-backend-zypp.cpp.o -MF backends/zypp/libpk_backend_zypp.so.p/pk-backend-zypp.cpp.o.d -o backends/zypp/libpk_backend_zypp.so.p/pk-backend-zypp.cpp.o -c ../backends/zypp/pk-backend-zypp.cpp
../backends/zypp/pk-backend-zypp.cpp:637:1: error: no previous declaration for 'gboolean zypp_logging()' [-Werror=missing-declarations]
  637 | zypp_logging ()
      | ^~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:683:1: error: no previous declaration for 'gboolean zypp_is_development_repo(zypp::RepoInfo)' [-Werror=missing-declarations]
  683 | zypp_is_development_repo (RepoInfo repo)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:692:1: error: no previous declaration for 'gboolean zypp_is_valid_repo(PkBackendJob*, zypp::RepoInfo)' [-Werror=missing-declarations]
  692 | zypp_is_valid_repo (PkBackendJob *job, RepoInfo repo)
      | ^~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:713:1: error: no previous declaration for 'zypp::ResPool zypp_build_pool(zypp::ZYpp::Ptr, gboolean)' [-Werror=missing-declarations]
  713 | zypp_build_pool (ZYpp::Ptr zypp, gboolean include_local)
      | ^~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:774:1: error: no previous declaration for 'zypp::target::rpm::RpmHeader::constPtr zypp_get_rpmHeader(const std::string&, zypp::Edition)' [-Werror=missing-declarations]
  774 | zypp_get_rpmHeader (const string &name, Edition edition)
      | ^~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:790:1: error: no previous declaration for 'PkGroupEnum get_enum_group(const std::string&)' [-Werror=missing-declarations]
  790 | get_enum_group (const string &group_)
      | ^~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:845:1: error: no previous declaration for 'void zypp_get_packages_by_name(const gchar*, zypp::ResKind, std::vector<zypp::sat::Solvable>&, gboolean)' [-Werror=missing-declarations]
  845 | zypp_get_packages_by_name (const gchar *package_name,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:867:1: error: no previous declaration for 'void zypp_get_packages_by_file(zypp::ZYpp::Ptr, const gchar*, std::vector<zypp::sat::Solvable>&)' [-Werror=missing-declarations]
  867 | zypp_get_packages_by_file (ZYpp::Ptr zypp,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:899:1: error: no previous declaration for 'bool zypp_package_is_local(const gchar*)' [-Werror=missing-declarations]
  899 | zypp_package_is_local (const gchar *package_id)
      | ^~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:920:1: error: no previous declaration for 'zypp::sat::Solvable zypp_get_package_by_id(const gchar*)' [-Werror=missing-declarations]
  920 | zypp_get_package_by_id (const gchar *package_id)
      | ^~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:985:1: error: no previous declaration for 'zypp::RepoInfo zypp_get_Repository(PkBackendJob*, const gchar*)' [-Werror=missing-declarations]
  985 | zypp_get_Repository (PkBackendJob *job, const gchar *alias)
      | ^~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp:1175:1: error: no previous declaration for 'void zypp_emit_filtered_packages_in_list(PkBackendJob*, PkBitfield, const std::vector<zypp::sat::Solvable>&)' [-Werror=missing-declarations]
 1175 | zypp_emit_filtered_packages_in_list (PkBackendJob *job, PkBitfield filters, const vector<sat::Solvable> &v)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function 'void zypp_backend_finished_error(PkBackendJob*, PkErrorEnum, const char*, ...)':
../backends/zypp/pk-backend-zypp.cpp:1803:35: warning: function 'void zypp_backend_finished_error(PkBackendJob*, PkErrorEnum, const char*, ...)' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
 1803 |         buffer = g_strdup_vprintf (format, args);
      |                  ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function 'void pk_backend_upgrade_system_thread(PkBackendJob*, GVariant*, gpointer)':
../backends/zypp/pk-backend-zypp.cpp:3576:23: warning: unused variable 'restart' [-Wunused-variable]
 3576 |         PkRestartEnum restart = PK_RESTART_ENUM_NONE;
      |                       ^~~~~~~
../backends/zypp/pk-backend-zypp.cpp: In function 'void backend_what_provides_thread(PkBackendJob*, GVariant*, gpointer)':
../backends/zypp/pk-backend-zypp.cpp:3847:62: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
 3847 |                                                              (const gpointer) make<ResObject>(*it)->summary().c_str (),
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.