Packet-Clearing-House / DNSAuth

Go-lang app to aggregate DNS queries to 1 minute buckets and write them to influxdb
MIT License
2 stars 2 forks source link

Log Name Issues - FQDN Limitation #29

Open jcdmacleod opened 5 years ago

jcdmacleod commented 5 years ago

DNSAuth doesn’t accept a file unless it is:

mon-01.pop.example.net_2018-12-29.05-59.dmp

This fails:

mon-01.pop.example.com_2018-12-29.05-59.dmp

I have not tried other tlds, but .com certainly fails. The files are just ignored, a rename causes them to be ingested instantly.

I will posted this under PDP too.

mrjones-plip commented 5 years ago

@unix1 - when you're next in the DNSAuth code, can you confirm we actually only accept the .net TLD in the FQDN? We can triage this ticket accordingly after that.

unix1 commented 5 years ago

@Ths2-9Y-LqJt6 that is correct. The aggregate function has net_ hardcoded in file name parsing and it expects it there.

mrjones-plip commented 5 years ago

@unix1 - great, thanks for the confirmation. If this is as easy of a fix as i think it is, please grab when you're next doing a cycle of work. No rush.

Conversely, if it's hard, or will have possible unknown reproductions, let's hold off until this can be the primary ticket you're working on.

@jcdmacleod - thanks for your patience while we work through this!

unix1 commented 5 years ago

@Ths2-9Y-LqJt6 this should be very simple indeed.