[Chapter 6] comment argument in create_comment() as CommentCreate instance

PacktPublishing / Building-Data-Science-Applications-with-FastAPI

Building Data Science Applications with FastAPI, Published by Packt

MIT License

299 stars 152 forks source link

[Chapter 6] comment argument in create_comment() as CommentCreate instance #12

Closed AlessandroMiola closed 1 year ago

AlessandroMiola commented 1 year ago

Hi François, first off, thanks for your amazing book! Very straight to the point in presenting the core concepts of FastAPI and its ecosystem :)

I'd just like to point out a possible typo (though quite irrelevant) in the create_comment definition in Tortoise section. If I'm not wrong, in the spirit of the previous examples the comment argument should rather be type-hinted as a CommentCreate instance.

frankie567 commented 1 year ago

Hi @AlessandroMiola 👋

Yes, you're right! In this case, it doesn't make much difference, but it should definitely be CommentCreate!

Packt and I are currently working on a Second Edition of the book, set to release this summer. Stay tuned!