search

PacktPublishing / C-Sharp-Data-Structures-and-Algorithms---Second-Edition

C# Data Structures and Algorithms - Second Edition by Packt Publishing
MIT License
26 stars 19 forks source link

Fix chapter08 dependent #8

Open iankode opened 4 months ago

iankode commented 4 months ago

resolves Issue #7

marcinjamro commented 4 months ago

Hello!

Thank you for submitting your changes to the code. It looks like someone has modified the code I included in the book and made changes that make it incorrect. As soon as I received notifications about your pull requests, I immediately contacted the publisher and asked to use the exact same version of the code that I provided. I would like to apologize for this situation, but it was not caused by me. I hope the publisher fixes this as soon as possible.

Thanks again for your help and I hope that you enjoy the book!

Have a nice day! Marcin

iankode commented 4 months ago

Marcin, Hi

Thank you for your prompt reply.

I wasn't sure if you were responding to my Issues/PRs or the supplementary email[below] I sent to Packt to alert interested parties

I was considering a couple of other niggles that I may get around to proposing [work permitting]

We will see whether Packt admit to tinkering during the final polish, and whether they Credit me [read-receipts OK but no reply yet].

I note your mention of upcoming training so please keep me posted.

Best wishes, IanK

From: Marcin Jamro @.> Sent: Tuesday, May 7, 2024 11:13 AM To: PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition @.> Cc: iankode @.>; Author @.> Subject: Re: [PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition] Fix chapter08 dependent (PR #8)

Hello!

Thank you for submitting your changes to the code. It looks like someone has modified the code I included in the book and made changes that make it incorrect. As soon as I received notifications about your pull requests, I immediately contacted the publisher and asked to use the exact same version of the code that I provided. I would like to apologize for this situation, but it was not caused by me. I hope the publisher fixes this as soon as possible.

Thanks again for your help and I hope that you enjoy the book!

Have a nice day! Marcin

- Reply to this email directly, view it on GitHubhttps://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/pull/8#issuecomment-2097944668, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARYJPSM7N2NFCEJLR7HPPJTZBCSLFAVCNFSM6AAAAABHKRVX3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXHE2DINRWHA. You are receiving this because you authored the thread.Message ID: @.**@.>>

From: Ian Kode @.**@.> Sent: Tuesday, May 7, 2024 10:28 AM To: @.**@.> Cc: 'Packt Customer Care' @.**@.> Subject: "C# Data Structures and Algorithms - Second Edition" ISBN 9781803248271

Dear Packt,

I have been reading a colleague's copy of this bookhttps://www.packtpub.com/product/c-data-structures-and-algorithms-second-edition/9781803248271, but I found several errors with the code downloadhttps://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/tree/main (as hosted on GitHub)

Problem Issue PR Missing standard GH files

1https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/issues/1

2https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/pull/2

Chapter03 project doesn't compile

3https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/issues/3

4https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/pull/4

Chapter07 project doesn't compile

5https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/issues/5

6https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/pull/6

Chapter08 project doesn't compile

7https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/issues/7

8https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/pull/8

These are provided with goodwill to author Dr Jamro and Packt as enhancement (please review and consider for update and any 3e release)

Would be nice to receive Credits from Packt to justify my time & effort preparing these contributions :)

Regards, IanK

marcinjamro commented 4 months ago

Hello!

Thank you for the reply. I hope the publisher will quickly replace the code with its correct version. I must admit that I was very surprised by what I saw in the repository, because unfortunately it was not what I sent to the publisher. Anyway, thank you very much for drawing attention to the problem, because it was thanks to your feedback that I learned about the problem and was also able to react. This will have a positive impact on other developers who want to use the code, as well. So, thank you once again!

Once the publisher places the correct version in the repository, I will be happy to hear your ideas on how the code could be further improved. Feel free to let me know! Each such feedback is very valuable and thanks to it we can further improve our skills. I would also like to get to know you, so if you want, please add me as your friend on LinkedIn.

Have a nice day! Marcin