search

PacktPublishing / Deep-Learning-with-TensorFlow-2-and-Keras

Deep Learning with TensorFlow 2 and Keras, published by Packt
MIT License
309 stars 210 forks source link

Wrong in alice_text_generator.py #4

Closed v3551G closed 3 years ago

v3551G commented 4 years ago

alice_text_generator.py: open(p, mode='r').read() -> open(p, mode='r', encoding='utf-8').read()

sujitpal commented 3 years ago

Thank you, for maximum portability, the encoding should be provided (especially for platforms whose default encoding is not utf-8. I have made the change and it should be available shortly in a PR.

sujitpal commented 3 years ago

Change applied via PR (https://github.com/PacktPublishing/Deep-Learning-with-TensorFlow-2-and-Keras/pull/6), awaiting merge.