Possible bug in Chapter08/lib/data.py

PacktPublishing / Deep-Reinforcement-Learning-Hands-On

Hands-on Deep Reinforcement Learning, published by Packt

MIT License

2.83k stars 1.28k forks source link

Closed educob closed 5 years ago

educob commented 5 years ago

Hi.

in line 33 it asks if prev_vals is not None but then it's not used.

if fix_open_price and prev_vals is not None:
                ppo, pph, ppl, ppc, ppv = vals

I think line 34 should be: ppo, pph, ppl, ppc, ppv = prev_vals

Thanks.

Transigent commented 5 years ago

I just came here to suggest exactly the same fix.

Shmuma commented 5 years ago

Thanks! Fixed in master