search

PacktPublishing / Hands-On-Microservices-with-Spring-Boot-and-Spring-Cloud

Hands-On Microservices with Spring Boot and Spring Cloud, published by Packt
MIT License
464 stars 406 forks source link

CircuitBreakerOpenException removed #7

Closed HabeebCycle closed 4 years ago

HabeebCycle commented 4 years ago

CircuitBreakerOpenException.class is deprecated and removed from the library : Replaced with CallNotPermittedException.class

.onErrorReturn(CallNotPermittedException.class, getProductFallbackValue(productId)), instead of .onErrorReturn(CircuitBreakerOpenException.class, getProductFallbackValue(productId)),

magnus-larsson commented 4 years ago

Hello Habeeb and thanks for your pull request!

This git repository contains the source code for the book Hands-On Microservices with Spring Boot and Spring Cloud , published by Packt.

When it comes to Resilience4j, this book uses version 0.14.1 of Resilience4j:

https://github.com/PacktPublishing/Hands-On-Microservices-with-Spring-Boot-and-Spring-Cloud/blob/595feae17383a9cdd831b83691c9cddf1140e487/Chapter13/microservices/product-composite-service/build.gradle#L24

Since the book is already released, I can not update the version of Resilience4j in this git repo. Since the class CallNotPermittedException was introduced in later versions of Resilience4j I can not accept this pull request.

Hope you understand, Magnus.

P.S. I plan to publish an updated version of the code in another git repo, reflecting the latest versions of Spring Boot, Kubernetes, Istio, et al. In that git repo I will for sure apply your pull request!

magnus-larsson commented 4 years ago

Handled by issue #8.