search

PacktPublishing / Hands-On-Software-Engineering-with-Golang

Hands-On Software Engineering with Golang, published by Packt
MIT License
426 stars 127 forks source link

Install correct golang-migrate version when testing with go modules disabled #12

Closed achilleasa closed 3 years ago

achilleasa commented 3 years ago

This fixes an issue when running the CI tests with go modules disabled where go get cannot find the correct golang-migrate version thus causing the CI tests to fail.

codecov-io commented 3 years ago

Codecov Report

Merging #12 (0644cec) into master (7e40809) will decrease coverage by 2.59%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   77.33%   74.73%   -2.60%     
==========================================
  Files          65       65              
  Lines        3507     3020     -487     
==========================================
- Hits         2712     2257     -455     
+ Misses        514      482      -32     
  Partials      281      281
Impacted Files Coverage Δ
Chapter07/crawler/privnet/detector.go 66.66% <0.00%> (-8.34%) :arrow_down:
Chapter12/linksrus/pagerank/service/worker.go 50.00% <0.00%> (-7.70%) :arrow_down:
Chapter07/crawler/graph_updater.go 52.38% <0.00%> (-7.62%) :arrow_down:
Chapter04/dependency/dependency.go 75.00% <0.00%> (-6.40%) :arrow_down:
Chapter04/pinger/pinger.go 43.75% <0.00%> (-6.25%) :arrow_down:
Chapter04/dialer/retrying_dialer.go 65.00% <0.00%> (-5.84%) :arrow_down:
Chapter04/chat/chat.go 80.00% <0.00%> (-5.72%) :arrow_down:
Chapter06/linkgraph/store/cdb/iterator.go 73.33% <0.00%> (-5.62%) :arrow_down:
Chapter08/pagerank/config.go 33.33% <0.00%> (-5.13%) :arrow_down:
Chapter07/pipeline/stage.go 70.10% <0.00%> (-5.12%) :arrow_down:
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8c3739...0644cec. Read the comment docs.