search

PacktPublishing / Learn-WinUI-3-Second-Edition

Learn WinUI 3.0, Second Edition, published by Packt
MIT License
23 stars 8 forks source link

Leveraging the MVVM Toolkit (last section on chapter 3) #2

Open DrAvriLev opened 9 months ago

DrAvriLev commented 9 months ago

Hi, I'm sorry to tell you that on that section you got me all confused...

Can you please elaborate on those changes that must be taken in order to complete the MainViewModel.cs file? The explaination is too succint, I think.

The script published on Github regarding that file under the tag "complete" in chapter three is not compatible with the one shown on your book. Is there a print typo? Or editing issues?

Another (big) issue concerns the section as shown on the content to the left (on the Packt website) - they are one number bigger than the actual chapter number, which is very confusing to the reader, althogh you specify the correct chapter to use in the thechnical requirements paragraph.

Best regards and happy new year, Dr. Avri

binaryboy71 commented 5 months ago

I'm also having huge issues with chapter 3. The listing in the book is nowhere near what is on github, and I cannot get chapter 3 to compile and run at all using what is in the book. The only way I can get chapter 3 to work is to download the completed files from github and replace my project wih those. Chapter 3 also does not read well in the book, looks like it has been rushed out without being properly checked and edited?

DrAvriLev commented 5 months ago

Dear binaryboy71, I'm sorry to tell you that I think that the author of this title doesn't give a sh** about its readers who unfortunately decided to buy his book... Otherwise he would have responded to my query that was made some four months ago! Another thing, appealing to Packt publishing for help on that issue did not solved anything!

binaryboy71 commented 5 months ago

Thanks DrAvriLev - I'll keep plugging away with the rest of the chapters to see if I can make progress, but if the rest is as bad as chapter 3 I think a review listing these problems on amazon will be the outcome.

DrAvriLev commented 5 months ago

Hi, I found the guy...

Sent him a message saying: Dear Mr. Ashcraft, please take a moment to review the post I made and the response I got on GitHub regarding your "Lean WinUi3" title... I'll appreciate if you take this opportunity to clarify and elaborate on the subject involved. Thank you so much, Dr. Lev

Hope it will help...

alvinashcraft commented 5 months ago

Hi @DrAvriLev. Thanks for reaching out. I do care what my readers think of the book, and I am sorry that the notification for your initial issue post got lost somewhere on my end. It looks like it came through over the 2023 holidays, and probably got mixed in with the notifications for my work repos. I don't check this repo often, because you can see yours is the only issue ever filed. It's not active at all.

Can you provide some more details about which code snippets from the chapter do not match with the solution in GitHub? The folks at Packt sometimes require abbreviated code blocks in the book to keep within their standards for the length of code blocks and the max length of a chapter. I'm sorry if any inconsistencies made it into the final edition. We did have two technical editors testing the code and a final edit pass to compare all GitHub code to the book's code. Something must have evaded those checks here.

By the way, when you get to Chapter 6, there is a missing instruction. I created a pull request in November that corrects the mistake in GitHub, and the Packt editors were notified about it. https://github.com/PacktPublishing/Learn-WinUI-3-Second-Edition/pull/1

alvinashcraft commented 5 months ago

Also, if you have specific issues that you find in the book's text, the online errata submission form is the best way to get these resolved quickly. I only have access to create branches and pull requests for problems in the GitHub code. The Packt editors can take errata submissions and make corrections to the book itself.