Incorrect query in Chapter 09

PacktPublishing / Machine-Learning-with-BigQuery-ML

Machine Learning with BigQuery ML, published by Packt

MIT License

30 stars 20 forks source link

Incorrect query in Chapter 09 #1

Closed sathishvj closed 3 years ago

sathishvj commented 3 years ago

https://github.com/PacktPublishing/Machine-Learning-with-BigQuery-ML/blob/3e6a80569794cb75de6667898b9788247ba8abee/Chapter09/09_matrix_factorization.sql#L36

Query seems to be wrong. I think this should be the correct query.

SELECT
  *
FROM
  ML.EVALUATE(MODEL `09_recommendation_engine.purchase_recommender`,
    (
    SELECT * FROM `09_recommendation_engine.product_purchases`));

ManikandanKurup-Packt commented 3 years ago

Hi @sathishvj Thank you for your insights. This book is still in production so these are not finalized. But we'll surely have a look into it.

alessandromarrandino commented 3 years ago

Hi @sathishvj, thanks for your comment. I've double checked and the query runs in a proper way (see screenshot below)

sathishvj commented 3 years ago

I don't remember this much now, but what is the "product_visits" table? It has not been seen before.