PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
514 stars 65 forks source link

Linux build fixes #11

Closed sndels closed 1 year ago

sndels commented 1 year ago

I ran into some errors when compiling with gcc-9 and cmake 3.22.1 on my Ubuntu 22.04 install. Most of these seem pretty straightforward and/or fix some chapters having a different flavor of copy-paste. I also fixed the build under clang (14) while I was at it.

The assimp .so thing was a bit weird with ld complaining about invalid file formats. I assume the extra files were supposed to be a chain of symlinks and I think it should be fine to just have the versioned .so.

sndels commented 1 year ago

Actually, looks like I had libassimp installed as a package and linking the .so from binaries did require having the non-versioned name when I removed the package.

sndels commented 1 year ago

Ok, there's something weird on my system with assimp so I removed the .so tinkering entirely.

sndels commented 1 year ago

Looks like it was just a file type thing and git does indeed support symlinks as a native type. With this, the files should clone as symlinks instead of regular text on linux.

theWatchmen commented 1 year ago

Thanks for sending this through! I think I uploaded the .so files from Windows and it lost the symlink. I will test on my system before merging to make sure I haven't missed anything else :)