search

PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
514 stars 65 forks source link

Uninitialized bindless descriptor fix. #26

Closed dorian-apanel-intel closed 1 year ago

dorian-apanel-intel commented 1 year ago

This moves bindless descriptor update before queue submit. Additionally it removes limit of updated descriptors per frame to make sure that each accessed array element is initialized.

Currently done for Chapter 2 and 3.

Related to #23

theWatchmen commented 1 year ago

I'll merge as it is, but we might need to revisit removing the limit per frame. I think the idea was trying to reduce the number of descriptors updated per frame to reduce CPU cost.

EDIT: I would also like to move us away having to use dummy textures for unused slots.

dorian-apanel-intel commented 1 year ago

Thanks, verified using a24996a1ac95ff253104e87adffd4c277f5b26d9 on Chapters 2-6.

Chapter 7 is currently hanging on Arc, but I currently have some other task to do first.