search

PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
514 stars 65 forks source link

usability issue: the camera rotated when drag the imgui's window in demo chapter1 #38

Closed jsjtxietian closed 1 year ago

jsjtxietian commented 1 year ago

When I tried to drag imgui's window in the demo in chapter 1, the camera rotated with it, and it feels a little annoying. This is not a problem in other chapters, because other chapters use the game_camera class to manage camera movement and rotation, in which ImGui::IsAnyItemHovered() has been used to block events.

jsjtxietian commented 1 year ago

I have already created a pr including a quick solution for this. But in all events it's just a temporary solution since it may not be a good practice. A better solution might be to have some sort of layers that events are either passed through or blocked by them.

theWatchmen commented 1 year ago

Thanks for the fix! If you're happy with the change, feel free to close this issue.