PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
514 stars 65 forks source link

So much differences in code between chapter 1 and 2, undocumented #49

Closed Gaetz closed 9 months ago

Gaetz commented 9 months ago

Hello, I am using your book, and comparing chapter 1's and 2's code, I have spotted a lot of differences, not directly linked with chapter's 2 content.

I can see the lighting changed, and there is mipmap support. Would it be possible to get a list of intended changes so that I can understand the code by comparing it ?

theWatchmen commented 9 months ago

Yes, some of the changes are not strictly related to the chapter - we should have probably added them to chapter 1 as a starting point. I admit it's a bit hard to isolate the code that is purely related to the chapter. However I think we highlighted most (if not all) of the relevant code for chapter 2 in the book. There might be some lines missing to avoid making the code too long or verbose, but it should provide a good guide to isolate the intended changes.

These boil down to:

Hope this helps, let us know if you have any further questions!

Gaetz commented 9 months ago

Ok, thank you very much. I code-compared chapter 2 and 1 and reintegrated changes.