search

PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
514 stars 65 forks source link

projected_p does not get negated. #55

Closed FlexW closed 3 weeks ago

FlexW commented 2 months ago

Shouldn't the projected_p here and in the following lines negated like in the book on page 168: https://github.com/PacktPublishing/Mastering-Graphics-Programming-with-Vulkan/blob/a03272b227a64a85a7b32b89ee5362671835f7d6/source/chapter7/graphics/render_scene.cpp#L2104

theWatchmen commented 1 month ago

I think this could be a typo in the book or we changed something in the implementation after we wrote the chapter and forgot to update it. The code is correct, if you restored the negative sign the rendering will be wrong.

theWatchmen commented 3 weeks ago

Closing for lack of activity.