VOLK_IMPLEMENTATION is also defined after including volk.h

PacktPublishing / The-Modern-Vulkan-Cookbook

The Modern Vulkan Cookbook published by Packt

MIT License

68 stars 6 forks source link

Open ohmaya opened 4 months ago

ohmaya commented 4 months ago

https://github.com/zeux/volk "In exactly one source file, define VOLK_IMPLEMENTATION before including volk.h."

Well, VOLK_IMPLEMENTATION is defined twice in this book's code base:

Thanks.

preetishkakkar commented 4 months ago

Yes, that seems like unnecessary, but I don't think it has any side effects. We shall remove it.

ohmaya commented 4 months ago

The only side effect is confusion, I believe. : )

preetishkakkar commented 4 months ago

Agreed. I will remove it