search

PacktPublishing / Vulkan-Cookbook

Code repository for Vulkan Cookbook by Packt
MIT License
816 stars 109 forks source link

Update 19 Increasing the performance through increasing the number of… #16

Open richardebel opened 2 years ago

richardebel commented 2 years ago

… separately rendered frames.h

Changed 5 references to r-value references to fix build errors for mingw64-gcc and VS std c++20

ButchDean commented 1 year ago

A few of questions:

  1. What errors were you getting?
  2. l-value references and r-value references are two very different things. I can't see how changing the function signature is a fix. How do you know there is not a better fix?
  3. If you were getting build errors, how did you verify faster performance from just using l-value references if the code refused to build? This pull request looks like it is for two different reasons that don't quite make sense.
  4. This is not c++20 code. Why are you building with the c++20 standard? The existing standard in CMakeTests.txt clearly states c++11.