search

Paco8 / plugin.video.skyott

Skyshowtime addon for Kodi
GNU General Public License v2.0
22 stars 7 forks source link

Allows for separate Dolby Vision and HDR10 settings in UHD #28

Closed Liqianyu closed 1 year ago

Liqianyu commented 1 year ago

In the latest add-on version (v0.4.3), Dolby Vision and HDR10 support are enabled by default if UHD is enabled. This is incorrect, as not all 4K TVs support Dolby Vision, and some do not even support HDR10.

So it should be allowed to enable HDR10\Dolby Vision in UHD separate setting.

Paco8 commented 1 year ago

So does this mean that if the 4K option is enabled then two other options should appear, one to enable DolbyVision and another for HDR10?

Liqianyu commented 1 year ago

So does this mean that if the 4K option is enabled then two other options should appear, one to enable DolbyVision and another for HDR10?

Yes, that's what it means. And should allow simultaneous selection (which is what is currently the case), as Peacock does not have Dolby Vision for all content. should provide 4K SDR content without Dolby Vision and HDR10 turned on, but I have not tested it.

Paco8 commented 1 year ago

Let me know if the issue is fixed in this package: plugin.video.skyott-0.4.3-2.zip

Liqianyu commented 1 year ago

I tested this version and it works fine. Add-ons can now display 4K SDR\HDR10\Dolby Vision.

Also I noticed that the Fix audio and subtitle language names feature removes the Audio Description (AD) code. This is not correct. ad is not a country code in Peacock.

It is also possible to change the Manifest to allow Kodi to correctly label Dolby Atmos tracks, although Peacock only has Dolby Atmos for the movie Furious 7 (2015). Currently Kodi will recognize the track as DD+ 5.1ch.

Paco8 commented 1 year ago

I think the problem with the AD code is fixed in version 0.4.4.