PactInteractive / image-downloader

Download images from the web more easily. A browser extension for Google Chrome, Microsoft Edge, and Brave.
https://chrome.google.com/webstore/detail/image-downloader/cnpniohnfphhjihaiiggeabnkjhpaldj
805 stars 296 forks source link

request: option to download only links or only images shown #2

Closed Owyn closed 11 years ago

Owyn commented 12 years ago

Now it makes a solid list of images and images by links, would be very nice to divide

vdsabev commented 12 years ago

Hey, sorry for the delay, I haven't forgotten about this. The thing is, I just finished implementing some important changes to fix the extension for Chrome v21+.

About your request: if I understand correctly, you have a set of links to images on the page and you only want to download those, without including other "junk" images like icons, etc. Have you tried the filter feature? For example, if the links have some part in common, typing that common string will narrow down the result.

I'm just trying to understand the exact use case that you want this for, otherwise, it shouldn't take too long to implement it, I would just prefer to avoid cluttering the UI any more.

Owyn commented 12 years ago

Case is when filter won't help, like thumbnail is www.website.com/image1.jpg and actual image is www.website.com/image2.jpg etc, so it would be great to be able to filter image depending on how they were capture by "href" link or by "src" of <img" object. + it would be a very fast filter with great usability for gallerie downloading so you don't have to investigate link addresses and just click one button to select only images found by "href"

+can I write another suggestion here? Recently I noticed that picture downloader becomes useless for websites whichi only shows images when you have referrer of the website, so without referrer you would only get 404 errors instead of actual images (example of such website - www.pixiv.net) - so I was wondering if it's possible to make referrer for downloading images?

+2nd thing, some websites ban you if you download images too fast, is it possible to make a timeout between every download? configurable preferable (like a second or few)

Thank you for your reply.

2012/7/11 Vladimir Sabev reply@reply.github.com:

Hey, sorry for the delay, I haven't forgotten about this. The thing is, I just finished implementing some important changes to fix the extension for Chrome v21+.

About your request: if I understand correctly, you have a set of links to images on the page and you only want to download those, without including other "junk" images like icons, etc. Have you tried the filter feature? For example, if the links have some part in common, typing that common string will narrow down the result.

I'm just trying to understand the exact use case that you want this for, otherwise, it shouldn't take too long to implement it, I would just prefer to avoid cluttering the UI any more.


Reply to this email directly or view it on GitHub: https://github.com/vdsabev/image_downloader/issues/2#issuecomment-6890779

vdsabev commented 12 years ago

Okay, I think I made a crude version of the first feature you requested, could you see if that works for you: https://docs.google.com/open?id=0BwnS3WNEN-naQU5ES2NmZVVhNWM

About the other suggestions:

  1. I didn't really understand the first one about the 404 errors. Could you please rephrase that? I'm not really sure what you mean by "referrer".
  2. I've already experimented with different ways to trigger the download since Chrome v21 stopped supporting my original method due to security reasons, but I eventually came up with a totally different solution. Implementing timeouts is a cool idea though, I'll certainly think about it. But I'm not sure what you mean when you say that the site is "banning" you? Is that normal - does it occur if you download the images very fast by hand (some sort of security measure of the site)? Or does the extension download one image and then stop? Because I just fixed that issue (occurred in Chrome v21+) and it should be working in the extension pack I sent you.

Which version of Chrome are you using by the way?

Owyn commented 12 years ago

That's it :-) Works perfectly and very handy Plus I see you implemented a timeout already, now it adds an images to downloading each few seconds or so

Another small suggestion which came up just now after testing this new version is to show text "starting downloading N images" under download button after pressing it (text would dissapear after few seconds) because now when I press "download" button - in extension nothing happens (download happens normally but it may be confusing when you are downloading many images from few pages and when you click "download" you don't know either button worked or those new images being downloaded are from previous page where you already have clicked "download"

  1. 404 error (or 403 or it may be any other error or just an empty page or fake image saying "do not leach" is an error html page given to you by server instaed of an image when website owner sets an anti-leach protection so other websites can't directly link to his images, - such things making image downloading not being able to download anything at all referrer is http://en.wikipedia.org/wiki/HTTP_referer
  2. Extensiions downloaded about 7 images and then nothing, I tried to open the website and it wasn't loadting at all - it banned my IP for so much downloads at once, website opened fine with proxy or web anonymizer

I'm using 20.0.1132.47 m

2012/7/11 Vladimir Sabev reply@reply.github.com:

sure

vdsabev commented 12 years ago

Plus I see you implemented a timeout already, now it adds an images to downloading each few seconds or so

No, what I actually did was to change the download mechanism to support newer versions of Chrome. Prior to version 21, Chrome had no problem with a page requesting multiple downloads. In v21+, due to security reasons, it pops a yellow bar asking the user whether they want to allow the page to download multiple files.

But I understand the need for a timer and I will work on that, I just have to figure out a way to avoid clutter in the UI. I think the options screen would be a suitable place to allow users to show/hide these extra filters, so if they don't use some of them they can just hide them.

I'll also look into the referer issue, I have to admit I'm not very familiar with the concept. I guess I'll work on an option to allow users to spoof it somehow to avoid this security measure. The site you provided should be a nice starting point.

The "Downloading N images" is also a good suggestion, I was already thinking about doing something like that. I have a bunch of little ideas, really, but not much time to work on them. Overall, thanks for your very valuable input :)

By the way, the Chrome Web Store now also supports bugs, questions and feature suggestions (instead of only reviews): https://chrome.google.com/webstore/support/cnpniohnfphhjihaiiggeabnkjhpaldj?#feature You could try to use that system, maybe more people can participate in the discussions that way.

Owyn commented 12 years ago

Didn't know about new web store, wrote few things there too ^_^

vdsabev commented 12 years ago

Sure, I saw that :) I'm working on the wildcards & saving filter options right now, and version 1.0.13 is already live (just published) with the "Downloading X images..." notification + some UI enhancements.