search

PadLex / SvgToGcode

MIT License
46 stars 27 forks source link

Fix scale in px #22

Closed odaki closed 2 years ago

odaki commented 2 years ago

Hello.

I've noticed that some of my SVGs are generating G-Code that is larger in scale than it should be. I also noticed that the red path for debugging was not scaled correctly.

I have fixed these issues, so please merge them if they seem to be OK. I am aware of no problems with svg and gcode generated by running "automated_testing.py".

The fix for the debug path generation, in particular, is not beautiful code, and I think I should refactor it, but I think it's better than having it malfunction.

When investigating the problem, it was useful to use the debugging features of VSCode. It would be nice if you could add a definition for debugging.

odaki commented 2 years ago

This is just my opinion. Since the accuracy of the G-Code to be generated is high, even if there is no problem with the G-Code generated by the automatic test, it would be difficult to tell if there is a problem due to differences.

I think the third decimal place is appropriate from the accuracy of modern machines.

PadLex commented 2 years ago

Looks great, thank you!

odaki commented 2 years ago

Thank you very much. I'll put out a small pull request later to harmonize with #21.