PadLex / SvgToGcode

MIT License
46 stars 27 forks source link

Adjustment with fix for negative viewbox #23

Closed odaki closed 2 years ago

odaki commented 2 years ago

Hello again.

My pull request from yesterday does not fully address the fix regarding viewBox with negative values. A few additional fixes are needed.

I checked the G-Code and svg generated using 'automated_testing.py' and it looks fine.

Please check the test results and if everything is fine, please merge my modifications.

PadLex commented 2 years ago

I'm not able to test it right now but your changes make sense. I'll test everything before creating a new release.

Thank you for your contributions!

odaki commented 2 years ago

Thank you for your quick response.

As for drawing for debug, I have found that inkscape does not display correctly unless laser.py also supports viewBox, so I think it would be better to refactor the viewBox handling in the official release, taking into account the modification of laser.py. Thanks for letting me use your great code. Please keep up the good work.