search

PadLex / SvgToGcode

MIT License
46 stars 27 forks source link

fix arrows not showing #5

Closed nineff closed 3 years ago

PadLex commented 3 years ago

I'm sorry I didn't get back to you sooner. I thought I had replied, I must have I forgotten to hit send. Anyway, could you clarify what you're referring to when you say that arrows aren't showing? As far as I can tell they are drawn. I made them intentionally small, perhaps we should allow the user to change the arrow size?

PadLex commented 3 years ago

Oh, make sure to include the arrow defs generated by the arrow_defs() method in your svg file. Otherwise the arrows won't render.

nineff commented 3 years ago

I'm sorry I didn't get back to you sooner. I thought I had replied, I must have I forgotten to hit send. Anyway, could you clarify what you're referring to when you say that arrows aren't showing? As far as I can tell they are drawn. I made them intentionally small, perhaps we should allow the user to change the arrow size?

And sorry for my delayed response now.

I did not try to use this Repo alone, I did use it together with the Inkscape extension (and there I activated the corresponding debug options). The Paths where drawn but the arrows did simply not show up. Maybe they were smaller than the linewidth?

User-changeable arrow size would be nice, however I would not expose this setting to the UI in the Inkscape extension to avoid cluttering it with too many detail-level settings. A Variable to be changed in the code via the user, a command line argument or something like that should suffice. I think the best option would however be to scale the arrow according to the linewidth, if this is possible?