PadWorld-Entertainment / worldofpadman

World of PADMAN game repository
https://worldofpadman.net
Other
37 stars 8 forks source link

Color black (^8) gets ignored in the player name in the chat #238

Closed VesuviusVenox closed 7 months ago

VesuviusVenox commented 7 months ago

Description of issue: It only seems to affect player names. If your name has the color black in it, it just gets ignored and converts to the adjacent color.

Steps to reproduce: Change your name to have some black letters in it and then open score board or type something in chat.

kai-li-wop commented 7 months ago

I had a quick test in ioquake3. There it is ignored in the chat, the name field and the scoreboard but not when typing directly in the console. In WoP it is ignored in the chat, the name field but not in the scoreboard and not when typing directly in the console.

kai-li-wop commented 7 months ago

@VesuviusVenox: Turn's out it is not a bug, it's a feature. The code comment states:

// Disallow color black in names to prevent players from getting advantage playing in front of black backgrounds

I know it is arguable since we have the glow skin feature, so enemies can be highlighted a lot to be more visible, even with dark names, but the name can in fact cover a tiny player being far away. I think we will keep it as is. So no fix for this apart more people from the community wish this to be changed.