PadWorld-Entertainment / worldofpadman

World of PADMAN game repository
https://worldofpadman.net
Other
39 stars 9 forks source link

UI: team order menu actions not working properly #43

Open mgerhardy opened 3 years ago

mgerhardy commented 3 years ago

BotMatchMessage indices and ui_teamorders.c looks out of sync

NUM_TEAM_ORDERS and teamOrders array should maybe match the message types:

#define MSG_NEWLEADER 1           // new leader
#define MSG_ENTERGAME 2           // enter game message
#define MSG_GOFORBALLOON 3        // accompany someone
#define MSG_STARTTEAMLEADERSHIP 4 // someone wants to become the team leader
#define MSG_WHOISTEAMLAEDER 5     // who is the team leader
#define MSG_GETITEM 6             // get an item
#define MSG_MAKELOVE 7            //
#define MSG_DROPCART 8            //
#define MSG_WRONGWALL 9           //
#define MSG_CATCHME 10            //

#define NUM_CTF_ORDERS 7
static const char *ctfOrders[] = {
    "I am the leader", "Defend the base",      "Follow me", "Get enemy lolly", "Camp here",
    "Report",          "I relinquish command", NULL};
static const char *ctfMessages[] = {"I am the leader",
                                    "%s defend the base",
                                    "%s follow me",
                                    "%s get enemy lolly",
                                    "%s camp here",
                                    "%s report",
                                    "I stop being the leader",
                                    NULL};

#define NUM_TEAM_ORDERS 7 // raute: 6 -> 7
static const char *teamOrders[] = {
    "I am the leader", "Follow me", "Roam", "Camp here", "Report", "Give cartridges", "I relinquish Command", NULL};
static const char *teamMessages[] = {"I am the leader",
                                     "%s follow me",
                                     "%s roam",
                                     "%s camp here",
                                     "%s report",
                                     "%s give your cartridges to me",
                                     "I stop being the leader",
                                     NULL};

trap_BotFindMatch might not find the order text

mgerhardy commented 3 years ago

Also the ui_teamOrder command should get added to the ui - and a key should get bound to it.

kai-li-wop commented 3 years ago

There is a key to call it, press "F3". We should stop the menu music to play, which is also a bug. Did not want to open an extra issue ticket.

mgerhardy commented 3 years ago

http://www.kbs.twi.tudelft.nl/docs/MSc/2001/Waveren_Jean-Paul_van/thesis.pdf page 80ff

kai-li-wop commented 3 years ago

Just as additional info, while I tested bot functions in vQ3, the questions mentioned in chapter 16.3 (page 84) don't seem to work in vQ3 either. So I don't know if they simply don't work in WoP either or were never implemented.

kai-li-wop commented 2 years ago

Todo