search

PadWorld-Entertainment / worldofpadman

World of PADMAN game repository
https://worldofpadman.net
Other
39 stars 9 forks source link

Crosshair and automated Mashine gun energy bar in ctl #59

Closed MancusNemo closed 2 years ago

MancusNemo commented 2 years ago

Hello,

look at the energy bar over or on top of the automated Machine gun you can build in Capture the Lolly mode. Now put the Crosshair on the energy bar of the Machine gun and it turns it colour into it of the energy bar. Bildschirmfoto vom 2021-11-28 16-15-44 Bildschirmfoto vom 2021-11-28 16-16-04

kai-li-wop commented 2 years ago

@MancusNemo Please, can you confirm this also with other crosshairs selected?

MancusNemo commented 2 years ago

Pictures saying more than worlds! I think its in all crosshairs! Bildschirmfoto vom 2021-11-29 13-57-05 Bildschirmfoto vom 2021-11-29 13-57-27 Bildschirmfoto vom 2021-11-29 13-59-12 Bildschirmfoto vom 2021-11-29 13-59-41 Bildschirmfoto vom 2021-11-29 14-10-59 Bildschirmfoto vom 2021-11-29 14-14-13 s!

kai-li-wop commented 2 years ago

OK, looks like a order sorting issue to me. So the BamBam life bar needs to go behind the cross hair.

mgerhardy commented 2 years ago

CG_Draw2D is rather huge - I will try to split it up to ease the reordering without breaking stuff

the relevant part is CG_DrawBambamIcon which should come before CG_DrawCrosshair

mgerhardy commented 2 years ago

Since dd112587dea0b2f96c243faa1c688e5ffa41de4f it would be CG_DrawEntityIcons() call that should either happen before CG_DrawCrosshair() or vice versa.

kai-li-wop commented 2 years ago

@mgerhardy: I just tested your changes and found out while playing from 2 clients on a LAN server that the health bar of the BAMBAM is not shown any more. It is completely missing. Health of your own team's BAMBAMs should be indicated. I am not sure if it was also indicated of opposing team's BAMBAMs. Need to check for that.

kai-li-wop commented 2 years ago

I think with bc0e809eab408741626a9f42744b078a85b3c335 I fixed the issue that entity icons were not shown to players any more. So those "help/hint" icons of health stations, SYC teleporter and BB boxes should work again. This should also apply to the BamBam health bar, which I could not test right now. I think it is possible to test if the crosshair and health bar order is correct now, which was the task stated the original issue.

3aTmE commented 2 years ago

Image

I can Confirm the Issue as fixed ! 👍

kai-li-wop commented 2 years ago

@3aTmE: Is the crosshair in front of the energy bar of the bambam for sure? Maybe to test with some of the opaque crosshairs instead of the semitransparent wop design crosshairs. I cannot distinguish from the screenshot if the crosshair is in front of behind the energy bar.

kai-li-wop commented 2 years ago

Ok, just tested it myself with an opaque crosshair. Looks good so far.

shot0002