Padax / w-components

JavaScript library based on Web Components.
MIT License
22 stars 2 forks source link

Add Integrated Component - Dialog #25

Closed nizniz187 closed 2 years ago

cwpeng commented 3 years ago

Element Structure: `

`

Custom Event:

yakkowu commented 2 years ago

Working on how to make shadow effects of the box-shadow CSS property look more naturally, and define it.

yakkowu commented 2 years ago

TASK COMPLETED!

In the last meeting, @cwpeng suggested that there should be a general style and an alert style, but I think it is enough to directly share the same set of components. Here I would like to propose that in addition to the user can customise the desired alert what the message is (like the Preview, you can check the last title of this comment, it's just changes color or add some emoji), it would be better to categorize it more formally in a common set of components called "Alerts" (Like MUI and Bootstrap.)

If you still need to split the Dialog into "Warning", "General", "Successful", etc. into independent types, we can discuss it again 🙂

⤷ Here's the currently file in Figma

Overview

Types

Three of types:

By the way, the Dialog does not have only one Body module as any cases. Therefore, it is not included in this types, just only three of them.

On the background

Preview

yakkowu commented 2 years ago

Update the Default sets

image

According to @cwpeng suggestion, here needs a default types: Confirm Dialog and Alert Dialog for this Dialog component. ⤷ Here's the currently file in Figma.

yakkowu commented 2 years ago

Update the Default sets

According to @cwpeng suggestion, here needs a default types: Confirm Dialog and Alert Dialog for this Dialog component. ⤷ Here's the currently file in Figma.

image

According to the previous comment, the default sets style are all added the view height and the background with overlay.

cwpeng commented 2 years ago

Add attributes:

Attributes stand for default settings for dialog, when open dialog by open method, user can pass settings to overwrite defaults dynamically.

nizniz187 commented 2 years ago

Is this issue done and reviewed and ok to be closed?

cwpeng commented 2 years ago

I think it's done.