search

PaddeK / node-maxmind-db

This is the pure Node API for reading MaxMind DB files. MaxMind DB is a binary file format that stores data indexed by IP address subnets (IPv4 or IPv6).
GNU Lesser General Public License v2.1
88 stars 25 forks source link

The /test alone bloats up this module's size by over 10000% #13

Open CamiloMM opened 9 years ago

CamiloMM commented 9 years ago

Having such a huge-ass .mmdb file in the /test dir bloats the package from < 300kb to > 29mb. That's over 10000% increase in size for something that virtually nobody will ever use.

Please think of the children and download this file on-demand for tests (MaxMind doesn't change the URL so it would be easy).

                  he can't bear it

Do you see that polar bear? He's sad because his rainforest is melting, his ozone layer is being fracked, he's almost ran out of Coca-Cola and his hard-drive is full of bloated NPM modules, and it's all your fault.

How can he save that naughty asian panda porn now? :( Please fix. For the pandas. For the future.

oschwald commented 9 years ago

Maxmind also provides small test databases.

CamiloMM commented 9 years ago

That's neat, but they're still several megabytes in size (GeoIP2-City-Test.mmdb is 19mb).

oschwald commented 9 years ago

I think you are misreading the file size. That file is 19 kb in size.

CamiloMM commented 9 years ago

You're right, I read "19.093 kb" as "19,093 kb". That size is perfectly fine to publish on NPM!

behcet commented 9 years ago

Please consider using .npmignore to exclude files when publishing to npm

knoxcard commented 5 years ago

https://github.com/runk/node-maxmind