Closed rajeshsegu closed 9 years ago
Also, is there a reason why there is 4 space indent at places and 2 space indent at other places ? I like the 2 space indent better. If we agree on something we can make this more uniform. Thanks.
@EaterOfCode @PaddeK any thing more that you guys want me to fix ?
sorry for the late reply, my personal favor is on 4 spaces as the original code was 4 space indent. I may have ruined it by mixing tabs with it. the code I wrote for this project is extremely bad. (Im sorry @PaddeK). the only thing that really still needs to be fixed is caching as lookups take alot of time.
I have made a patch for adding path lookup and ipv4 start node caching but never found the motivation afterwards to finish it: here.
@EaterOfCode @PaddeK Please do review
@EaterOfCode @PaddeK lets merge this if you guys do not have more review comments. Thanks in advance.
I hated the tests in this library as they used just colors to know if a test is passed or failed. I have implemented tapejs tests for this module to make sure we can integrate them with any ci to validate every commit that goes into this module.
now you can run:
npm run test
1..26 tests 26 pass 26 ok
npm run coverage