1.21 update [PR coming]

jshipley commented 2 months ago

I was really enjoying this mod in 1.20.1, but I've mostly been playing 1.21. I spent some time yesterday and today updating Blazing Bamboo to 1.21. You can look at the current status here:

fabric-1.21-1.0.1

forge-1.21-1.0.1

neoforge-1.21-1.0.1

I've tested them all on 1.21 and 1.21.1. If nothing major changes, they may be able to load on future 1.21.x releases as well.

I didn't change the 1.0.1 version, because these changes mostly just changed registration and datapack stuff to keep it working on 1.21.

The reason they're not a PR already is that there are still a few remaining problems (and could be more that I haven't found):

[Forge] - The compat recipes are logging errors when the mods they depend on are not installed - even though they have the forge:mod_loaded condition and shouldn't be logging errors

I'm assuming that it's a Forge bug related to the 1.21 datapack changes. In any case, it's not causing any problems other than logging errors, lots of other 1.21 mods will probably run into the same thing, and it's Forge on 1.21 when Neoforge will probably be getting most of the attention/support.

[Neoforge/Forge] - When a blazing bamboo chest raft is spawned, the game crashes with this error: java.lang.IllegalStateException: Entity class net.paddedshaman.blazingbamboo.entity.BBChestRaftEntity has not defined synched data value 15

I'm a bit stuck here. I'm having trouble seeing what could even be setting a synched data value of 15. It seems to be happening down in the Entity class, and the same error happens if I remove defineSynchedData/setVariant from the BBChestRaftEntity class. I'm still thinking that it's most likely an error related to the DATA_ID_TYPE members in Boat and BBChestRaftEntity.

Here's the weirdest thing: I can place a vanilla boat with chest and get the same crash. If I disable the Blazing Bamboo mod and start the game again then I am able to place the vanilla boat with chest. Then if I enable Blazing Bamboo and start Minecraft again with a vanilla boat with chest already in the world I am able to place the blazing bamboo boat with chest.

Once that bug is fixed, I'm planning on submitting PRs for the 3 1.21 branches. Feel free to do whatever you want with this. I've already met my main goal of being able to have blazing bamboo in 1.21 Fabric :)

PS. I thought I liked being able to turn the blazing bamboo into blaze rods and gunpowder. I didn't even realize that there were lava boats, and discovering those made me like the mod a lot more. Thanks for making a fun mod!

jshipley commented 2 months ago

The boat crash was fixed, and PRs have been submitted: #3, #4, #5

PaddedShaman commented 2 months ago

Wow... This is incredible! I didn't expect anyone to like my mod so much that they'd update it for me!!

Thank you for your hard work on all this. You even gave me support for all three major mod loaders... and extra mod compatibilities!

I'm gonna merge the PRs now, but I haven't finished learning how to mod 1.21 yet. I want to be sure I fully understand the changes before publishing these versions publicly, but when I do, I will give you all the credit!

PaddedShaman commented 2 months ago

Okay so I have no idea what I'm doing lmao, I'll have to look more closely at the PRs later because ideally I'd like them to go to a new branch named [modloader]-[mcversion]-[modversion] instead of committing them to the existing 1.20 branches. So like the fabric one should go to a new branch named fabric-1.21-1.0.1. Give me some time to work on this, but I'll get everything up and running!

jshipley commented 1 month ago

I don't know if you've figured it out yet. I'm not sure how you could do it through the PR, but you could pull the branches from my fork and then push them in.

Something like this:

git remote add jship git@github.com:jshipley/BlazingBamboo.git
git fetch jship fabric-1.21-1.0.1
git push origin fabric-1.21-1.0.1
git remote remove jship

(it might have to be git push --set-upstream origin ...)

If you have any questions about what I changed or why, please let me know.

After you have a 1.21 Fabric branch, I can fix/redo the PR for the 1.21 Simple Copper Pipes compat so that it compares against the 1.21 branch instead of the 1.20.1 branch. Hopefully that's just changing a dropdown in the github web interface.

jshipley commented 3 weeks ago

If you'd like, you could also create new 1.21 branches of the 1.20 code, and I can submit/update PRs against those new branches.

PaddedShaman / BlazingBamboo

1.21 update [PR coming] #2