please remove outdated patch - Githubissues

PaddiM8 / kalker

Scientific calculator with math syntax that supports user-defined variables and functions, complex numbers, and estimation of derivatives and integrals

https://kalker.xyz

MIT License

1.64k stars 74 forks source link

please remove outdated patch #88

Closed 0323pin closed 2 years ago

0323pin commented 2 years ago

Patching of Cargo.toml is no longer needed. The relevant commit on gmp-mpfr-sys has been merged and is part of the 1.4.8 release. I've removed the patch locally and regenerated Cargo.lock but for some reason I'm not able to push the changes and create a PR. It seems like some more changes (nix flakes?) are needed to address conflicts flagged by git when pushing, hence my request here.

Thanks!

PaddiM8 commented 2 years ago

Oh nice! Should be sorted out now. I updated the nix flake as well (still working on getting the lock file updated though, nix SEGABRTs on my machine haha)

0323pin commented 2 years ago

@PaddiM8 Thank you! I'll try to merge the update on NetBSD during the weekend.

0323pin commented 2 years ago

@PaddiM8 hmm... somehow Cargo.lock still points to 1.4.7. It didn't on my machine.

[[package]]
name = "gmp-mpfr-sys"
version = "1.4.7"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a146a7357ce9573bdcc416fc4a99b960e166e72d8eaffa7c59966d51866b5bfb"
dependencies = [
 "libc",
 "winapi",
]

0323pin commented 2 years ago

@PaddiM8 Haha, Sweden 🤣

Jag väntar tills du har lyckats få Cargo.lock uppdaterat. När jag körde cargo generate-lockfile fick jag med gmp-mpfr-sys-1.4.8

PaddiM8 commented 2 years ago

@0323pin Ahh ja behövde manuellt säga till den att uppdatera till 1.4.8! Nu används 1.4.8.

0323pin commented 2 years ago

Merged, https://mail-index.netbsd.org/pkgsrc-changes/2022/06/04/msg255518.html