PaddlePaddle / Anakin

High performance Cross-platform Inference-engine, you could run Anakin on x86-cpu,arm, nv-gpu, amd-gpu,bitmain and cambricon devices.
https://anakin.baidu.com/
Apache License 2.0
531 stars 135 forks source link

使用开源代码可否遵守开源协议? #531

Closed daquexian closed 5 years ago

daquexian commented 5 years ago

相关 issue:https://github.com/PaddlePaddle/Anakin/issues/527

https://github.com/PaddlePaddle/Anakin/issues/527 里面 @yiicy 说

感谢指出问题,我们最开始的GEMM借鉴了compute library,现在sgemm.cpp里的接口已经弃用了,统一使用sgemm_prepacked.cpp里的接口,实现上也做了相应的变化,sgemm_prepacked.cpp的xblock将按照l2 cache大小划分

我理解为你们承认了你们使用了 acl 的开源代码,那么请遵守它们的 MIT 协议。没有人关心你们的 block 怎么划分

在同一个 issue 里面,@throneclay 说

没人回复这个就关了,如果有问题可以随时跟我们联系

我和 @izp001 都进一步回复了,请你们也正面给出回应

tpoisonooo commented 5 years ago

完了,大缺要怼到底了。最好还是撤回代码...最近刚好没啥出轨的新闻。

BUG1989 commented 5 years ago

之前paddle-mobile的int8抄袭ncnn int8的,后面可是删除相关代码并做出了书面道歉的哟,希望贵组能准守开源协议的游戏规则。

daquexian commented 5 years ago

附上相关代码

Anakin: https://github.com/PaddlePaddle/Anakin/blob/bc5ac0a03798d36826478855b1083562e633e979/saber/funcs/impl/arm/neon/impl/sgemm_arm.cpp#L565

ACL(随手搜到的): https://github.com/ARM-software/ComputeLibrary/blob/52ba29e936b8e711e8acdfe819e36f884d4f3fe1/src/core/NEON/kernels/arm_gemm/kernels/a32_sgemm_8x6/a53.cpp#L32

可以看到注释是一样的,借鉴的痕迹也很明显

daquexian commented 5 years ago

ACL 的 MIT 协议:https://github.com/ARM-software/ComputeLibrary/blob/master/LICENSE

MIT License

Copyright (c) 2017-2019 ARM Software

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

xyoungli commented 5 years ago

ACL 的 MIT 协议:https://github.com/ARM-software/ComputeLibrary/blob/master/LICENSE

MIT License Copyright (c) 2017-2019 ARM Software Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

非常抱歉此问题带来的困扰。 添加和整合sgemm_arm这部分代码的目的是用来对比sgemm的性能,在基线对照代码的整理过程中,疏漏掉了里面ACL开源代码对应的MIT License,我们已对应加上license。 由于sgemm_arm.cpp、sgemm_arm.h只用于之前的对比测试,并未在Anakin其他代码中调用使用,会从repo中删除。 我们以后会对代码规范做更严格检查,感谢daquexian的监督和反馈。

tpoisonooo commented 5 years ago

改了就挺好,赞。 顺带提一句,anakin 这个名字并不讨喜,甚至有点令人反感,看完《星球大战》全集应该知道黑武士灭了多少人。好比有人给自己起名叫“王魔”、“李鬼“。

daquexian commented 5 years ago

Fixed by #533, Thanks!