PaddlePaddle / Paddle

PArallel Distributed Deep LEarning: Machine Learning Framework from Industrial Practice (『飞桨』核心框架,深度学习&机器学习高性能单机、分布式训练和跨平台部署)
http://www.paddlepaddle.org/
Apache License 2.0
21.66k stars 5.44k forks source link

【Hackathon 6th No.10】Add isin API to Paddle -part #64001

Open NKNaN opened 2 weeks ago

NKNaN commented 2 weeks ago

PR Category

User Experience

PR Types

New features

Description

rfcs: https://github.com/PaddlePaddle/community/pull/884

paddle-bot[bot] commented 2 weeks ago

你的PR提交成功,感谢你对开源项目的贡献! 请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。 Your PR has been submitted. Thanks for your contribution! Please wait for the result of CI firstly. See Paddle CI Manual for details.

NKNaN commented 5 days ago

@jeff41404 paddle.searchsorted currently does not support fp16 and bf16. I think the reason may be that the two input tensors' data type of paddle.searchsorted could be different, and since fp16 and bf16 has lower precision than float32 and float64, the comparision between them may be less meaningful.

jeff41404 commented 4 days ago

@jeff41404 paddle.searchsorted currently does not support fp16 and bf16. I think the reason may be that the two input tensors' data type of paddle.searchsorted could be different, and since fp16 and bf16 has lower precision than float32 and float64, the comparision between them may be less meaningful.

the logic of searchsorted also supports comparing two inputs with different data types. Registering the fp16 and bf16 data types in the Operator should support these two data types. searchsorted operator was developed many years ago, when fp16 and bf16 were not yet widely used, and it was not intentionally unsupported due to accuracy or lower precision.

NKNaN commented 4 days ago

the logic of searchsorted also supports comparing two inputs with different data types. Registering the fp16 and bf16 data types in the Operator should support these two data types. searchsorted operator was developed many years ago, when fp16 and bf16 were not yet widely used, and it was not intentionally unsupported due to accuracy or lower precision.

Got it. Let me update the searchsorted to support fp16 and bf16 first.