PaddlePaddle / Paddle

PArallel Distributed Deep LEarning: Machine Learning Framework from Industrial Practice (『飞桨』核心框架,深度学习&机器学习高性能单机、分布式训练和跨平台部署)
http://www.paddlepaddle.org/
Apache License 2.0
22.09k stars 5.55k forks source link

no execution permission in demo/semantic_role_labeling by default #705

Closed leonardgithub closed 7 years ago

leonardgithub commented 7 years ago

I use the paddledev/paddle:cpu-devel-latest image, but I found the sh and py files are without x permission in the folder /root/paddle/demo/semantic_role_labeling, It is recommended you add the x permission like other demo such as quick_start/*.sh

commands: chmod +x .sh chmod +x .py

backyes commented 7 years ago

@leonardgithub

Thanks for your report. :-)

I remember that he shell script will call python script indirectly. Generally, we will prefer to call shell script with sh some.sh. For source distribution, I think current solution would be better. :-)

leonardgithub commented 7 years ago

@backyes I agree with you, but why in other demo such as quick_start, the sh files have x permission. It is not consistent.

backyes commented 7 years ago

@leonardgithub

We will try to fix it, thanks.

backyes commented 7 years ago

@leonardgithub

Would like to contribute it to help us to make it perfect. :-)