search

PaddlePaddle / PaddleHelix

Bio-Computing Platform Featuring Large-Scale Representation Learning and Multi-Task Deep Learning “螺旋桨”生物计算工具集
Other
984 stars 222 forks source link

Misspecified keyword in the protein pretraining and prediction tutorial #148

Closed riversdark closed 2 years ago

riversdark commented 3 years ago

I'm looking at the TAPE protein pretraining tutorial, in the model config dict there is a keyword layer_num, but there is no such keyword argument in any of the TAPE models, only a n_layers argument. So whatever layer_num hidden layers we specify, since the models only search for the number of hidden layers with the n_layers keyword, and since there is no such keyword in model_config, it will always use the default value 8. Am I reading this right?

TLDR: I think the layer_num keyword in model configs should be n_layers.

linxd5 commented 3 years ago

hi, riversdark. All you say is right. In the current released version, we have not opened the config function fully, you need to revise the code directly if you want to change the config. Sorry for the bad use experience. We will complete the config function in the next released version. Thanks for your issue.

riversdark commented 3 years ago

Hey no need to apologize and thanks for all your great work! I guess I can close this now, or should I wait for you to do it?