PagerDuty / backstage-plugin-backend

PagerDuty plugin for Backstage - Backend
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
3 stars 6 forks source link

fix(oncall-api): return all users from lowest escalation level #33

Closed brianphillips closed 5 months ago

brianphillips commented 6 months ago

Description

Instead of return all users that match the escalation level of the first user returned in the oncall list, return users that match the lowest escalation level. Previously, if a higher escalation level user was the first item in the array, only users at that same level would be returned.

Issue number: Fixes PagerDuty/backstage-plugin-backend#34

Type of change

Checklist

If this is a breaking change 👇

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

brianphillips commented 6 months ago

@t1agob could you take a look at this please?

t1agob commented 5 months ago

Hi @brianphillips. Thanks for submitting this PR. I have tested it and it doesn't change the overall behaviour of the API and fixes the issue of not showing the ordered items.

Approved! I have changed the base branch to comply with our guidelines. I'll work on merging this to main and release a new version shortly.