PagerDuty / backstage-plugin-backend

PagerDuty plugin for Backstage - Backend
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
3 stars 6 forks source link

Invalid integration key results in mapping page crashing #68

Closed brianphillips closed 1 month ago

brianphillips commented 1 month ago

When trying to load the new pagerduty page with our existing software catalog, the page errors out due to the backend call returning a 404: image

I believe the issue is we have one (or more) backstage entities that reference a PagerDuty integration key that is invalid. On this line of code, the backend API endpoint returns a 404 if there are no matches for the integration key. I think might be better to handle this data quality issue more gracefully instead of throwing an exception.

t1agob commented 1 month ago

@brianphillips Reviewing your PR now

t1agob commented 1 month ago

This issue is now solved with #69 and available in version 0.7.2. Thanks @brianphillips for yet another contribution 🚀