PagerDuty / backstage-plugin-backend

PagerDuty plugin for Backstage - Backend
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
3 stars 8 forks source link

fix: add missing "return" statements after errors #83

Closed brianphillips closed 3 months ago

brianphillips commented 3 months ago

Description

When a route function returns an error early on in the function body (i.e. validating the presence of a field), it's important to not continue executing the function to ensure a) no undesired code is executed, and b) to avoid trying to emit headers multiple times.

Issue number: n/a

Type of change

Checklist

If this is a breaking change 👇

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.