PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
21 stars 5 forks source link

fix: correct client test case description #100

Closed mdb closed 1 month ago

mdb commented 1 month ago

Description

This corrects the it() description associated with the PagerDuty API client's handling of generic non-OK HTTP responses that are not 401s, 403s, or 404s. Previously, the test case claimed the client throws NotFoundErrors in such cases. This is not true; the client throws a generic descriptive error in such cases.

Thanks!

Issue number: (e.g. #123)

Type of change

Checklist

If this is a breaking change šŸ‘‡

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.