PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
23 stars 4 forks source link

Add support for disabling the `Edit` action on all rows of the PagerDutyPage component #124

Open alpinweis opened 1 month ago

alpinweis commented 1 month ago

Is your feature request related to a problem? Please describe. I'd like to be able to disable the possibility for users to use the Edit action of the PagerDutyPage component and use the PagerDutyPage mostly in a read-only mode.

Describe the solution you'd like I'd like to be able to disable the Edit action of the PagerDutyPage component from code using an option like disableEditAction, something similar to how it's done for ChangeEvents, e.g. <EntityPagerDutyCard disableChangeEvents>

Describe alternatives you've considered N/A

pd edit action

t1agob commented 1 month ago

Hey @alpinweis!

Quick question here for additional context...if you don't have the edit button, what would you use this page for? This page is mainly intended to provide a quick way of editing mappings.

alpinweis commented 1 month ago

@t1agob It helps find out quickly what services in our backstage instance do not have PagerDuty integration enabled yet. Also, having the mapping PagerDuty to backstage in a nice visual format is pretty helpful. In my org the preference is for having the integrations be done in code (helps keep track of changes), instead of by folks interactively/directly from the backstage UI

t1agob commented 1 month ago

Got it! Thanks for sharing. I'll review this then.

Btw, we have a feature request in the roadmap to open a PR in the Backstage entity source when a new mapping is defined on this page. Then, you could use the UI and still enforce code-first 😉