PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
24 stars 4 forks source link

On call engineers are duplicated #36

Closed jcoelho93 closed 10 months ago

jcoelho93 commented 10 months ago

Describe the bug

There are 2 issues with the list of on call engineers:

To Reproduce Steps to reproduce the behavior:

  1. Go to a service's page, with an escalation policy with multiple engineers
  2. The list of on call engineers will not display the primary on call
  3. The list of on call engineers will have some duplicates

Expected behavior

Screenshots

Screenshot 2023-11-08 at 13 27 38

Desktop (please complete the following information):

t1agob commented 10 months ago

Hi @jcoelho93! I was able to replicate the issue if I specify users individually or have multiple levels in the escalation policy. If I use a on-call schedule instead with just one level I only get the user currently on-call.

Can you please confirm that your use case fits into the first scenario? Thanks!

jcoelho93 commented 10 months ago

@t1agob yes, I confirm, we have an escalation policy with multiple levels.

t1agob commented 10 months ago

@jcoelho93 this issue has now been resolved and merged into next branch (#38) . It will be merged into main and released by the end of the week November 17.

I have solved the issues you reported and now the plugin only lists oncall users on escalation level 1 and no duplicates will show up. I have also added support for user's profile picture instead of the default dummy avatar icon.