search

PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
22 stars 5 forks source link

Plugin doesn't refresh from search #54

Closed shmaram closed 5 months ago

shmaram commented 5 months ago

Describe the bug When searching from the Backstage search modal the data of the plugin doesn't refresh

To Reproduce Steps to reproduce the behavior:

  1. Go to an entity that uses the plugin, you should see the PD data of that service (in the example - "acc") image
  2. Click on the "search" from the left pane image
  3. You should see the search modal
  4. select a different service from the modal data
  5. Look at the PD plugin and see that the data didn't change image

Expected behavior After clicking on a different service, the PD data should refresh

Screenshots Added in the steps above

Desktop (please complete the following information):

Additional context We are connecting the PD plugin using the annotation pagerduty.com/service-id and the package is using EntityPagerDutyCard from @pagerduty/backstage-plugin version: 0.7.3

t1agob commented 5 months ago

Thanks for reporting this bug @shmaram. With your detailed reproduction steps I was able to reproduce the bug and will start working on it immediately.

t1agob commented 5 months ago

@shmaram just to let you know that I've identified and fixed the issue reported yesterday (PR #55).

I'm working on getting this merged into main and release ASAP. I'll notify you here once it is done.

t1agob commented 5 months ago

This issue is now fixed and available on version 0.7.4. Thanks for reporting it @shmaram!

shmaram commented 5 months ago

Just check and it works like a charm! Thank you @t1agob for the fast response!