search

PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
21 stars 5 forks source link

Optionally remove 'create incident' button from card #67

Closed t1agob closed 2 months ago

t1agob commented 4 months ago

Is your feature request related to a problem? Please describe. Currently the PagerDuty Card shows the 'create incident' button even when configured with service-id only.

According to the documentation if we only use the service-id annotation on the service entity it will not be possible to create incidents and therefore the button becomes greyed-out.

Describe the solution you'd like To simplify the PagerDuty Card readability I would like the button to fully disappear when the card is configured as read-only or when service-id is the only annotation provided on the service entity configuration.

Additional context This feature was requested by @asandoval and @jerroydmoore.

t1agob commented 4 months ago

This requires a small change in the UI behaviour and therefore is tagged as good first issue for anyone from the community that would like to take it.

t1agob commented 3 months ago

This is now the default behaviour in the new PagerDutyCard UI released on version 0.10.0 of the frontend plugin. I will now proceed to close the issue.

t1agob commented 3 months ago

re-opening issue as it doesn't cover the scenario where integrationKey annotation is not provided.

t1agob commented 2 months ago

This feature has now been merged to next and will be release soon when merged to main.

This introduces a change in behaviour and hides the Create Incident button if the PagerDutyCard is marked as readonly AND if the integration-key annotation is not defined on the Entity level.