search

PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
25 stars 6 forks source link

Small sized PagerDutyCard component #86

Closed t1agob closed 7 months ago

t1agob commented 8 months ago

Is your feature request related to a problem? Please describe. Our Entity page has multiple tabs and we reserve the first one to smaller widgets to provide relevant and quick information to users. We then have specific tab for Operations where we would like to keep the existing card.

Describe the solution you'd like I would like to have a smaller card that shows the status of the service, the oncall engineer, service standards and eventually some statistics. Details on incidents are not necessary, we have the other PagerDuty card for that.

Describe alternatives you've considered We are considering building an internal-only custom component to expose only the information we need.

milenkotomic commented 7 months ago

Hi @t1agob, is this feature in active development? In our company we build a small card to our overview page that includes the status of the service and the on-call engineer, and would be happy to shared it

t1agob commented 7 months ago

Hello @milenkotomic! This feature is not being developed yet so if you want to contribute it to the community that would be great! I would start by looking into our contribution guidelines and create a PR.

I can work with you on reviewing this and making sure it's aligned with the other components from a UI/UX and API usage perspective.

milenkotomic commented 7 months ago

Hi @t1agob! I can't push to create a PR, I'm getting error 403, can you help me with that? Thanks!

t1agob commented 7 months ago

You should be able to fork the project, create your own branch and create a PR to next. Is this the process you followed?

milenkotomic commented 7 months ago

No, I misread the contributing guidelines, I was trying to push a branch straight to this repo, sorry.

t1agob commented 7 months ago

After gathering feedback from a few other folks I came up with a slight change to your PR. @milenkotomic What do you think of this?

👇 This shows the card with collapsable panels for insights and on-call.

image

👇 This one shows the same panel with the panels expanded.

image

You can still choose to disable booth tabs. Does that work?

milenkotomic commented 7 months ago

Hi @t1agob! Yes, it looks great, I'll try to make those changes as soon a I can

t1agob commented 7 months ago

no need to @milenkotomic. just pushed the changes to #95.

If you could pull the changes and try it out yourself and see if it works as expected I would appreciate. I can then merge the PR.

milenkotomic commented 7 months ago

It works as expected, I tried the different combinations of options and all of them worked perfect. There is a bit a commented code that should be removed in my opinion before the merge, but besides that everything is good @t1agob.

t1agob commented 7 months ago

Thanks for catching that. I'll clean it up before merging.

Thank you for your contribution. It really helped unblock this one.

t1agob commented 7 months ago

This is now merged and available as part of @pagerduty/backstage-plugin 0.12.0 version.