PagerDuty / backstage-plugin

PagerDuty plugin for Backstage
https://pagerduty.github.io/backstage-plugin-docs/index.html
Apache License 2.0
25 stars 6 forks source link

feat: hide trigger incident on missing integration key #88

Closed t1agob closed 8 months ago

t1agob commented 8 months ago

Description

This PR introduces a behaviour change when the integration key is missing from an entity configuration. Currently the behaviour is to disable the button but keep it on the screen.

After discussing the plugin with several customers, many shared with us that they don't want people to manually create incidents from Backstage as incidents are automatically created from alerts. Therefore we decided to remove the button if the integration key is not provided as part of the entity configuration, like we already do when the readonly parameter is passed to the PagerDutyCard.

This also allows us to save some valuable space in the PagerDutyCard.

Issue number: #67

Type of change

Checklist

If this is a breaking change 👇

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.