Support loading of creds from data bags

PagerDuty / chef-sumologic

Recipe for an unattended install of Sumo Logic's sumocollector via chef

9 stars 16 forks source link

Support loading of creds from data bags #26

Open shortdudey123 opened 9 years ago

shortdudey123 commented 9 years ago

Add support for encrypted data bags
Add support for unencrypted data bags
Add support for accessID and accessKey usage
Update doc to reflect correct attributes
Make old email and password attributes consistent w/ sumologic collector cookbook
Add test kitchen testing around data bag support

shortdudey123 commented 9 years ago

hmmm Tests pass locally but Travis is correct since the method has 42 lines and not 38 or less as configured in .rubocop_todo.yml... and rubocop is the same version

hostname:~/chef-sumologic username (support_ecrypted_data_bags)$ bundle exec rubocop libraries/sumo_source_provider.rb
Inspecting 1 file
.

1 file inspected, no offenses detected
hostname:~/chef-sumologic username (support_ecrypted_data_bags)$

shortdudey123 commented 9 years ago

@ranjib can you review this one last time and merge when you have a chance?

gswallow commented 9 years ago

Could you use strings, instead of symbols, to access node attributes in your change?

shortdudey123 commented 9 years ago

@gswallow you should be able to yes

gswallow commented 9 years ago

No, I mean, this pull request doesn't work for me. I had to change L127-136 of sumo_source_provider.rb to use strings, rather than symbols, when loading an encrypted data bag.

shortdudey123 commented 9 years ago

Ah gotcha

@ranjib can you update this please :)